Explain which key is META on common platforms #735
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As per usual, the CLA bot is wrong. |
|
@cvrebert Thanks for the PR. I can confirm that you have signed the CLA with matching name and email. |
|
I updated your first CLA signature to use the name that you have in your git config. |
| @@ -8,6 +8,8 @@ | |||
| <longdesc> | |||
| <p>Returns a boolean value (<code>true</code> or <code>false</code>) that indicates whether or not the <kbd>META</kbd> key was pressed at the time the event fired. | |||
| This key might map to an alternative key name on some platforms.</p> | |||
| <p>On Macintosh keyboards, the <a href="http://en.wikipedia.org/wiki/Command_key">Command key (⌘)</a> maps to the META key.</p> | |||
| <p>On Windows keyboards, the <a href="http://en.wikipedia.org/wiki/Windows_key">Windows key</a> maps to the META key.</p> | |||
There was a problem hiding this comment.
A few lines above this we wrapped META in <kbd> tags. I guess we should do that here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since almost nobody has an actual old-school Meta (◆) key on their keyboard these days, let's save everyone the cross-referencing trip and explain what
metaKeyrefers to in practice in the modern day.Sources: