val(): Updated description for the setter version#744
Closed
AurelioDeRosa wants to merge 3 commits into
Closed
Conversation
Member
I'm not sure we want to lock ourselves into that behavior. It's not terribly likely to change, but it's also not a great idea to pass in junk and let us sort it out. I'd rather not dignify (or encourage) it with recognition. |
Member
Author
|
Thank you for the feedback @gibson042. Anyone wants to comment before I update the PR? |
Member
Author
|
PR updated. |
Member
Author
|
Anyone keen to review this PR? |
Member
|
One question I have about this behavior after reading the changed text:
|
Member
Author
|
@gnarf Yes, it does. I'll update the PR accordingly. |
PR updated based on the feedback
Member
Author
|
Can you double check this PR @arthurvr? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: gh-712