wrapAll: change description of function argument #745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -14,8 +14,7 @@ | |||
| <signature> | |||
| <added>1.4</added> | |||
| <argument name="function" type="Function"> | |||
| <desc>A callback function returning the HTML content or jQuery object to wrap around the matched elements. Receives the index position of the element in the set as an argument. Within the function, <code>this</code> refers to the current element in the set.</desc> | |||
| <argument name="index" type="Integer" /> | |||
| <desc>A callback function returning the HTML content or jQuery object to wrap around all the matched elements. Within the function, <code>this</code> refers to the first element in the set. <strong>Prior to jQuery 3.0</strong>, the callback got called for every element in the set and received the index position of the element in the set as an argument.</desc> | |||
There was a problem hiding this comment.
How about changing "the callback got called" to "the callback was incorrectly called" because it was the wrong behavior.
There was a problem hiding this comment.
That sounds like a good idea 👍
@dmethvin Added. LGTY?
c8e5ece to
4ed5972
Compare
|
👍 |
arthurvr
added a commit
that referenced
this pull request
May 29, 2015
|
Closing as this is merged in the v3 branch. |
AurelioDeRosa
pushed a commit
that referenced
this pull request
May 23, 2016
timmywil
pushed a commit
that referenced
this pull request
Jun 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the v3 branch.
Fixes gh-605