wrapAll: change description of function argument #745
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
entries/wrapAll.xml
Outdated
Member
There was a problem hiding this comment.
How about changing "the callback got called" to "the callback was incorrectly called" because it was the wrong behavior.
Member
Author
There was a problem hiding this comment.
That sounds like a good idea 👍
@dmethvin Added. LGTY?
c8e5ece to
4ed5972
Compare
Member
|
👍 |
arthurvr
added a commit
that referenced
this pull request
May 29, 2015
Member
Author
|
Closing as this is merged in the v3 branch. |
AurelioDeRosa
pushed a commit
that referenced
this pull request
May 23, 2016
timmywil
pushed a commit
that referenced
this pull request
Jun 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the v3 branch.
Fixes gh-605