Promise objects also have the .promise method. #753
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e methods for a promise object.
Member
|
I agree, this LGTM. In general we are moving towards interoperation with standard Promise and thenables, but there is no reason I can think of to avoid documenting |
Member
|
Thanks! 👍 I'll land this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realize that code implementation does not necessarily dictate documentation, but the Promise type returned from various methods also contains the
.promise()method of the deferred object (and I think it has always been this way).This would simply officially document that behavior.
Discussion which prompted this: https://groups.google.com/d/msg/closure-compiler-discuss/qbNLjzp3OCw/fjNhLsv4regJ