-
Notifications
You must be signed in to change notification settings - Fork 264
Visible: Specified new behavior #789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This also affects |
You didn't give me the time :) PR updated. |
Merged with commit d0e7282. |
Why "will be"? Isn't this supposed to go live when jQuery 3 is released when the future tense won't make sense? |
@AurelioDeRosa We all open PRs and wait for code reviews before landing something and I'd prefer if you did so too. That's the point of PRs :) |
@arthurvr you saw this PR after ~30 seconds it was made and the only comment you had was
I took it as a LGTM. Simple as that, there is no need to paternalize. :) |
Yes, because I'm not going to review a PR when it's not complete yet. Just like everybody does, please wait for an LGTM, 👍 or alike comment. |
And for #779, you didn't have any comment yet ;) |
Fixes gh-737