Skip to content

Visible: Specified new behavior #789

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

AurelioDeRosa
Copy link
Member

Fixes gh-737

@arthurvr
Copy link
Member

This also affects :hidden so let's also add a note on that entry.

@AurelioDeRosa
Copy link
Member Author

You didn't give me the time :)

PR updated.

AurelioDeRosa added a commit that referenced this pull request Jul 27, 2015
@AurelioDeRosa
Copy link
Member Author

Merged with commit d0e7282.

@AurelioDeRosa AurelioDeRosa deleted the AurelioDeRosa-visible branch July 27, 2015 20:58
@mgol
Copy link
Member

mgol commented Jul 27, 2015

Why "will be"? Isn't this supposed to go live when jQuery 3 is released when the future tense won't make sense?

@arthurvr
Copy link
Member

@AurelioDeRosa We all open PRs and wait for code reviews before landing something and I'd prefer if you did so too. That's the point of PRs :)

@AurelioDeRosa
Copy link
Member Author

@arthurvr you saw this PR after ~30 seconds it was made and the only comment you had was

This also affects :hidden so let's also add a note on that entry.

I took it as a LGTM. Simple as that, there is no need to paternalize. :)

@arthurvr
Copy link
Member

you saw this PR after ~30 seconds it was made and the only comment you had was

Yes, because I'm not going to review a PR when it's not complete yet. Just like everybody does, please wait for an LGTM, 👍 or alike comment.

@arthurvr
Copy link
Member

And for #779, you didn't have any comment yet ;)

AurelioDeRosa added a commit that referenced this pull request May 23, 2016
timmywil pushed a commit that referenced this pull request Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants