Skip to content

Completed the list of copied props of jQuery.Event. #802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

andyli
Copy link
Contributor

@andyli andyli commented Sep 7, 2015

Source ref: https://github.com/jquery/jquery/blob/master/src/event.js (props, keyHooks.props, mouseHooks.props)

@dmethvin
Copy link
Member

This LGTM. It's adding the standard mouse and key event properties to the "also copied" list but since we say they can be undefined that covers the case for things like mouse properties on a key event well enough. Thanks @andyli!

@AurelioDeRosa
Copy link
Member

It looks good to me as well, thank you @andyli. Should I merge it?

@AurelioDeRosa AurelioDeRosa self-assigned this Sep 21, 2015
@kswedberg
Copy link
Member

@AurelioDeRosa , yes, please merge away! 👍

@arthurvr
Copy link
Member

👍 Thanks!

@andyli andyli deleted the event-props branch December 15, 2015 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants