Moved note about Global Ajax events to notes.xsl #805
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
notes.xsl
Outdated
Member
There was a problem hiding this comment.
Can you fix the indentation here?
2b0d888 to
a2ce793
Compare
Member
Author
|
Final review for this PR? |
Member
|
Looks accurate to me. I'm not sure we need this text in the note though. That text was important in the era between 1.8 and 1.9 to warn people it was going away, but now that it has gone away it seems that the only really important milestone from a docs standpoint is 1.9 where the behavior changed. |
Member
Author
|
So, should I keep the deletion of the note in all the files and keep in the |
Member
|
@AurelioDeRosa that sounds like a plan! |
Member
Author
|
PR updated. I'll wait for a final LGTM before merging. Thank you @dmethvin |
Member
|
LGTM thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #798