Skip to content

isNumeric: Updated description based on new behavior #819

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

AurelioDeRosa
Copy link
Member

Fixes gh-817

@AurelioDeRosa
Copy link
Member Author

@timmywil Does it match what you had in mind?

@AurelioDeRosa
Copy link
Member Author

@timmywil friendly ping.

@@ -10,6 +10,7 @@
</signature>
<longdesc>
<p>The <code>$.isNumeric()</code> method checks whether its argument represents a numeric value. If so, it returns <code>true</code>. Otherwise it returns <code>false</code>. The argument can be of any type.</p>
<p>As of jQuery 3.0 <code>$.isNumeric()</code> returns <code>true</code> only if the argument is of type <code>number</code>, or if it's of type <code>string</code> and it can be coerced into finite numbers. In all other cases, it returns <code>false</code>.</p>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe link to the types page to avoid confusion (http://api.jquery.com/Types/#Number)

@timmywil
Copy link
Member

Looks good.

AurelioDeRosa added a commit that referenced this pull request Nov 24, 2015
@AurelioDeRosa AurelioDeRosa deleted the is-numeric-v3 branch November 24, 2015 21:31
AurelioDeRosa added a commit that referenced this pull request May 23, 2016
timmywil pushed a commit that referenced this pull request Jun 9, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants