Skip to content

Document that addClass and removeClass change the attribute #846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

AurelioDeRosa
Copy link
Member

Fixes gh-814

@AurelioDeRosa
Copy link
Member Author

This PR is a bit redundant as it includes two paragraphs I've included in PR #813. However, I thought it was a good idea for two reasons. The first is that it reads better with a bit of context given by the copied paragraphs. The second is that it'll be easier to rebase when this branch will be merged into master.

@dmethvin
Copy link
Member

For people who like to skim documents or quote them out of context it might be good to reword this to say, "Before jQuery version 3.0, ..." in that first sentence.

@AurelioDeRosa
Copy link
Member Author

Wording updated.

@dmethvin
Copy link
Member

LGTM! Don't know what's going on with the Travis run.

@AurelioDeRosa
Copy link
Member Author

Cool. I'm merging it now.

About Trevis: this branch doesn't have a .travis.yml file.

@AurelioDeRosa
Copy link
Member Author

Closed via 4651f44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants