Document that addClass and removeClass change the attribute#846
Closed
AurelioDeRosa wants to merge 2 commits into
Closed
Document that addClass and removeClass change the attribute#846AurelioDeRosa wants to merge 2 commits into
AurelioDeRosa wants to merge 2 commits into
Conversation
Member
Author
|
This PR is a bit redundant as it includes two paragraphs I've included in PR #813. However, I thought it was a good idea for two reasons. The first is that it reads better with a bit of context given by the copied paragraphs. The second is that it'll be easier to rebase when this branch will be merged into master. |
Member
|
For people who like to skim documents or quote them out of context it might be good to reword this to say, "Before jQuery version 3.0, ..." in that first sentence. |
Member
Author
|
Wording updated. |
Member
|
LGTM! Don't know what's going on with the Travis run. |
Member
Author
|
Cool. I'm merging it now. About Trevis: this branch doesn't have a |
AurelioDeRosa
added a commit
that referenced
this pull request
Dec 15, 2015
Member
Author
|
Closed via 4651f44. |
AurelioDeRosa
added a commit
that referenced
this pull request
Dec 28, 2015
timmywil
pushed a commit
that referenced
this pull request
Jan 11, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes gh-814