attr: Document attr(key, null) to remove attribute #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition, introduce the `null` value type to more completely describe
the `attr` method's signature.
jQuery implements explicit support for this behavior [1]:
if ( value === null ) {
jQuery.removeAttr( elem, name );
return;
}
and also maintains unit tests to verify it [2]:
jQuery( "#name" ).attr( "name", null );
assert.equal( jQuery( "#name" ).attr( "name" ), undefined, "Remove name attribute" );
Fixes jquerygh-523
[1] https://github.com/jquery/jquery/blob/1823a715660a5f31dd7e05672e9ad020066256a9/src/attributes/attr.js#L55-L58
[2] https://github.com/jquery/jquery/blob/1823a715660a5f31dd7e05672e9ad020066256a9/test/unit/attributes.js#L283-L284
|
I suppose the explicit new |
| @@ -147,7 +147,8 @@ The title of the emphasis is:<div></div> | |||
| <argument name="value"> | |||
| <type name="String"/> | |||
| <type name="Number"/> | |||
| <desc>A value to set for the attribute.</desc> | |||
| <type name="Null"/> | |||
| <desc>A value to set for the attribute. If <code>null</code>, the specified attribute will be removed (as in <a href="/removeAttr/">.removeAttr()</a>).</desc> | |||
There was a problem hiding this comment.
Can you surround removeAttr() with the code tag?
|
All set, @AurelioDeRosa |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, introduce the
nullvalue type to more completely describethe
attrmethod's signature.jQuery implements explicit support for this behavior [1]:
and also maintains unit tests to verify it [2]:
Fixes gh-523
[1] https://github.com/jquery/jquery/blob/1823a715660a5f31dd7e05672e9ad020066256a9/src/attributes/attr.js#L55-L58
[2] https://github.com/jquery/jquery/blob/1823a715660a5f31dd7e05672e9ad020066256a9/test/unit/attributes.js#L283-L284