-
Notifications
You must be signed in to change notification settings - Fork 264
Made == to === #854
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Made == to === #854
Conversation
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
LGTM |
LGTM too, just need the CLA to be signed. |
I've signed the CLA, and updated my Github name to match, is there anything else I need to do to make it update? |
@dmethvin I think the reason why the label isn't updated is because there are still issues. Is that correct? |
The author of the git commit doesn't contain your last name, I think that's the problem. There are instructions here on how to fix it, just don't forget to fix the first commit too. |
Hi @vihanb. Would you mind fixing your commit so that I can merge this PR? |
So the first commit is the one that doesn't seem to be updating the name. I've tried running |
Specified parenthesis should be put around the numbers to avoid confusion for beginners
Oh okay, I've got it fixed |
Great, thank you. |
@jquery/content I need a small advice here. The user has created two commits with unrelated changes but both of them are good to merge. Should I ask the user to create a new PR out of the second commit? THe problem is that for the second I cannot use the usual Closes gh-XXX format. |
@AurelioDeRosa, If both commits look good, I think you should go ahead and merge them. After you push the changes, you can go to the issue covered by the second commit and manually post a comment saying "Closed by [SHA]." (replacing [SHA] with the actual commit sha). Sound reasonable? |
Unfortunately we don't have an issue open for that either. However, I can easily open one. |
Ah, I see. Yeah, open an issue, please. And thank you! |
Made all the
==
into===
in Types.html because===
is almost always better and promotes better practice.