Skip to content

Made == to === #854

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Made == to === #854

wants to merge 2 commits into from

Conversation

vihanb
Copy link

@vihanb vihanb commented Dec 27, 2015

Made all the == into === in Types.html because === is almost always better and promotes better practice.

@jquerybot
Copy link

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@AurelioDeRosa
Copy link
Member

LGTM

@dmethvin
Copy link
Member

LGTM too, just need the CLA to be signed.

@vihanb
Copy link
Author

vihanb commented Dec 29, 2015

I've signed the CLA, and updated my Github name to match, is there anything else I need to do to make it update?

@AurelioDeRosa
Copy link
Member

@dmethvin I think the reason why the label isn't updated is because there are still issues. Is that correct?

@arthurvr
Copy link
Member

The author of the git commit doesn't contain your last name, I think that's the problem. There are instructions here on how to fix it, just don't forget to fix the first commit too.

@AurelioDeRosa
Copy link
Member

Hi @vihanb. Would you mind fixing your commit so that I can merge this PR?

@vihanb
Copy link
Author

vihanb commented Jan 16, 2016

So the first commit is the one that doesn't seem to be updating the name. I've tried running git rebase -i and all that stuff but that didn't seem to fix it

Vihan Bhargava added 2 commits January 16, 2016 08:30
Specified parenthesis should be put around the numbers to avoid confusion for beginners
@vihanb
Copy link
Author

vihanb commented Jan 16, 2016

Oh okay, I've got it fixed

@AurelioDeRosa
Copy link
Member

Great, thank you.

@AurelioDeRosa
Copy link
Member

@jquery/content I need a small advice here. The user has created two commits with unrelated changes but both of them are good to merge. Should I ask the user to create a new PR out of the second commit? THe problem is that for the second I cannot use the usual Closes gh-XXX format.

@kswedberg
Copy link
Member

@AurelioDeRosa, If both commits look good, I think you should go ahead and merge them. After you push the changes, you can go to the issue covered by the second commit and manually post a comment saying "Closed by [SHA]." (replacing [SHA] with the actual commit sha). Sound reasonable?

@AurelioDeRosa
Copy link
Member

Unfortunately we don't have an issue open for that either. However, I can easily open one.

@kswedberg
Copy link
Member

Ah, I see. Yeah, open an issue, please. And thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

6 participants