Indicate where data will be passed in $.one doc#855
Conversation
|
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
b06a180 to
2beaa72
Compare
2beaa72 to
26342ba
Compare
|
The link definitely helps clarify things! As for all the now-discouraged "shortcut" methods, I would still prefer they just be defined in terms of the non-deprecated Right now the text for the shortcut methods is all copy/pasta/edit, but I think it could be done with a
Where METHOD is the title of that particular page, like |
|
Hi @cmisenas and thank you for your contribution. The PR looks good to me. Some notes: |
|
Sure @AurelioDeRosa, whatever works. It definitely affects them all but for whatever reason it seems like the selector in |
|
Landed, thanks @cmisenas! |
I only found the
dataafter inspectingeventfurther. This change will make it clearer where to getdata(and consistent with the docs for.one( events [, selector ] [, data ], handler )and.one( events [, selector ] [, data ] )).If people think it would be great to make this change for other jquery fns too, the following fns still use the old desc:
I'd be happy to make changes as part of this PR