Skip to content

Manipulation: fix after/before xml parsing#859

Closed
timmywil wants to merge 1 commit into
jquery:masterfrom
timmywil:after-before
Closed

Manipulation: fix after/before xml parsing#859
timmywil wants to merge 1 commit into
jquery:masterfrom
timmywil:after-before

Conversation

@timmywil
Copy link
Copy Markdown
Member

@timmywil timmywil commented Jan 7, 2016

I ran grunt deploy locally and ran into this error. Not sure why it's not happening in CI testing. This update seems to fix it.

@AurelioDeRosa
Copy link
Copy Markdown
Member

What operating system are you using? If it's Windows, I can try to replicate your issue. Also, what's the error?

@timmywil
Copy link
Copy Markdown
Member Author

timmywil commented Jan 7, 2016

I'm using Mac 10.11.2. Error is...

Running "build-xml-entries:all" (build-xml-entries) task
>> Error: element a: validity error : ID after-function already defined

@AurelioDeRosa
Copy link
Copy Markdown
Member

PR looks good to me, so I can merge. However, before doing it if anyone with a Mac could try it, we can understand the reason behind the error.

@timmywil
Copy link
Copy Markdown
Member Author

timmywil commented Jan 7, 2016

I don't think there's a danger in merging. I'm surprised Windows users don't see this error. There are duplicate names.

@timmywil timmywil closed this in 0811e8f Jan 8, 2016
@timmywil timmywil deleted the after-before branch January 8, 2016 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants