Manipulation: fix after/before xml parsing #859
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What operating system are you using? If it's Windows, I can try to replicate your issue. Also, what's the error? |
|
I'm using Mac 10.11.2. Error is... |
|
PR looks good to me, so I can merge. However, before doing it if anyone with a Mac could try it, we can understand the reason behind the error. |
|
I don't think there's a danger in merging. I'm surprised Windows users don't see this error. There are duplicate names. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
grunt deploylocally and ran into this error. Not sure why it's not happening in CI testing. This update seems to fix it.