Skip to content

added example with multiple events#881

Closed
vitaly-zdanevich wants to merge 3 commits into
jquery:masterfrom
vitaly-zdanevich:patch-1
Closed

added example with multiple events#881
vitaly-zdanevich wants to merge 3 commits into
jquery:masterfrom
vitaly-zdanevich:patch-1

Conversation

@vitaly-zdanevich
Copy link
Copy Markdown
Contributor

No description provided.

@jquerybot
Copy link
Copy Markdown

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@AurelioDeRosa
Copy link
Copy Markdown
Member

Hi @vitaly-zdanevich.

I'm fine with adding a new example but I'd like to improve the PR a bit. I'll add further comments inline.

Comment thread entries/on.xml Outdated
]]></code>
</example>
<example>
<desc>Multiple events:</desc>
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you expand the sentence to clarify what the ideal goal of your code is?

@AurelioDeRosa AurelioDeRosa self-assigned this Feb 11, 2016
@AurelioDeRosa
Copy link
Copy Markdown
Member

Hi @vitaly-zdanevich. Is there any specific reason why you have closed this PR?

@vitaly-zdanevich
Copy link
Copy Markdown
Contributor Author

@AurelioDeRosa I closed this PR just because I created new with correct branch-name and better commit. It would be better to commit to this PR?

@AurelioDeRosa
Copy link
Copy Markdown
Member

It's totally fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants