Skip to content

clarify documentation for outerWidth and outerHeight#883

Closed
IanKemp wants to merge 1 commit into
jquery:masterfrom
IanKemp:master
Closed

clarify documentation for outerWidth and outerHeight#883
IanKemp wants to merge 1 commit into
jquery:masterfrom
IanKemp:master

Conversation

@IanKemp
Copy link
Copy Markdown
Contributor

@IanKemp IanKemp commented Feb 10, 2016

Fixes #882.

@jquerybot
Copy link
Copy Markdown

Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA).

📝 Please visit http://contribute.jquery.org/CLA/ to sign.

After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know.


If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check.

@IanKemp
Copy link
Copy Markdown
Contributor Author

IanKemp commented Feb 10, 2016

I signed the CLA, plzkthx.

@AurelioDeRosa
Copy link
Copy Markdown
Member

The PR looks good to me but it seems there are still problems with the CLA.

@AurelioDeRosa AurelioDeRosa self-assigned this Feb 11, 2016
@IanKemp
Copy link
Copy Markdown
Contributor Author

IanKemp commented Feb 11, 2016

I don't know what's up with the CLA. I signed it but the "check CLA status" link doesn't work.

@agcolom
Copy link
Copy Markdown
Member

agcolom commented Feb 11, 2016

@IanKemp the issue with the CLA is that there is a mismatch with your email address. You signed the CLA with your gmail address, but the PR is associated with another email address, see https://patch-diff.githubusercontent.com/raw/jquery/api.jquery.com/pull/883.patch
If you sign again with your name and that email address, it'll be all green :-) thanks :-)

@IanKemp
Copy link
Copy Markdown
Contributor Author

IanKemp commented Feb 11, 2016

Ugh, my repo was setup with my work email address instead of my personal. Signed the CLA with the former, seems fine now, sorry for the trouble.

@agcolom
Copy link
Copy Markdown
Member

agcolom commented Feb 11, 2016

@IanKemp No worries at all and thanks very much for signing again and the PRs :-)

@AurelioDeRosa
Copy link
Copy Markdown
Member

Merged. Thank you @IanKemp.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants