jQuery.uniqueSort: Fixed category name

[AurelioDeRosa]

Fixes gh-908

[dmethvin]

Ah, so the encoded version works? Awesome!

[AurelioDeRosa]

@agcolom did you have the chance to double-check this?

[agcolom]

@AurelioDeRosa My local setup is no longer working for the core api (not sure what change broke it yet, and I cannot install anything as I get the error on npm install!) so I haven't been able to test this, sorry.

[kswedberg]

@AurelioDeRosa this needs a corresponding <category> entry in the categories.xml file. Unfortunately, when I try to add <category name="Version 1.12&amp;2.2" slug="1.12&amp;2.2">…</category>, I get "Warning: Invalid slug: 1.12&2.2." Using a hyphen (-) works. Maybe we should use that instead?

[kswedberg]

@AurelioDeRosa ugh, I think I spoke too soon. While I don't get the error when I use <category name="Version 1.12-2.2" slug="1.12-2.2"> (with hyphens). The build process seems to ignore it. Maybe there's a stricter check when adding the version than when validating it?

[AurelioDeRosa]

@kswedberg I managed to have the dash working. I think what was wrong is that $.uniqueSort() doesn't not include the category at the bottom of the file.

If everyone is happy, I can update the PR and merge it.

[kswedberg]

Aha! You're correct, @AurelioDeRosa . That was the missing piece of the puzzle. Thanks so much for looking into this. Please update and merge.

[AurelioDeRosa]

PR updated. I double checked and everything works correctly. As soon as I get approval, I'll merge it.

[mgol]

LGTM