-
Notifications
You must be signed in to change notification settings - Fork 264
Fix documentation for .val() #939
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request. It looks like this may be your first contribution to a jQuery Foundation project, if so we need you to sign our Contributor License Agreement (CLA). 📝 Please visit http://contribute.jquery.org/CLA/ to sign. After you signed, the PR is checked again automatically after a minute. If there's still an issue, please reply here to let us know. If you've already signed our CLA, it's possible your git author information doesn't match your CLA signature (both your name and email have to match), for more information, check the status of your CLA check. |
<argument name="value" type="String" /> | ||
<return type="String" /> | ||
<argument name="value" type="String" /> | ||
<return type="String" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I leave the trailing whitespace as is or is it fine?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whitespaces should be removed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
LGTM. |
Sorry, not LGTM. We don't have versioned docs, every page describes the API in all jQuery versions so we need to have all documented. See e.g. how the Could you try doing sth like that here? |
I didn't know how to handle the example properly because I couldn't find an example. Hope it's fine like this. |
I'd suggest to update the PR to have something like we have for // jQuery 1.4.3+
$( elements ).delegate( selector, events, data, handler );
// jQuery 1.7+
$( elements ).on( events, selector, data, handler ); |
How about // jQuery <3.0
var multipleValues = $( "#multiple" ).val() || [];
// jQuery 3.0+
var multipleValues = $( "#multiple" ).val()
|
Yeah, it looks good to me. |
Closed by 5689f1a |
See:
#828
jquery/jquery#2562
timmywil/jquery@4319c27
Fixes #828.