Dimensions: Document empty-context getters #998
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
mgol
reviewed
Nov 13, 2016
| @@ -9,7 +9,7 @@ | |||
| </signature> | |||
| <desc>Get the current computed height for the first element in the set of matched elements, including padding but not border.</desc> | |||
| <longdesc> | |||
| <p>This method returns the height of the element, including top and bottom padding, in pixels.</p> | |||
| <p>This method returns the height of the element, including top and bottom padding, in pixels. If called on an empty set of elements, returns <code>undefined</code> (<code>null</code> before jQuery 2.2.0).</p> | |||
There was a problem hiding this comment.
null before jQuery 3.0, not 2.2.0. Same below.
There was a problem hiding this comment.
Hmm, https://github.com/jquery/jquery/blame/master/src/dimensions.js#L50 must be lying somehow (or I'm misreading it). But you're right. Fixed.
|
LGTM, it can be landed as two commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-997