Skip to content

Fixed initSelector as it works directly on widget. #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Palestinian
Copy link

Please note that the correct way to set a new initial selector initSelector is $.mobile.widget.initSelector. As .initSelector doesn't work with .prototype.

Please note that the correct way to set a new initial selector `initSelector` is `$.mobile.widget.initSelector`. As `.initSelector` doesn't work with `.prototype`.
@arschmitz
Copy link
Member

@Palestinian Thank you for submitting this this I see you have signed our cla. However you did not use your full name only a last initial and in your git config you only have your first name and no last name we need these to match and be your full name.

If you can just resign the cla with your full name I will be happy to look at this.

@Palestinian
Copy link
Author

@arschmitz Sorry, I'm not experienced with GitHub. Could you please tell me what I should do? I've changed my name "Omar M. T." is that enough? Thank you :)

@Palestinian
Copy link
Author

@arschmitz I have just signed CLA with "Omar M. T.".

@arschmitz
Copy link
Member

@Palestinian i'm going to close this the name in your git config and that you sign the CLA with must match and be your full name. Your email must match as well. Please submit another pull request with these matching and ill review then.

@arschmitz arschmitz closed this Nov 5, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging this pull request may close these issues.

4 participants