Collapsible: Added contentTheme option and fixed theme default #293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this sounds ok maybe @gabrielschulhof or @uGoMobi can give it a second look just to be sure this is all sounds good though. |
| @@ -201,7 +209,7 @@ | |||
| </desc> | |||
| <type name="Boolean" /> | |||
| </option> | |||
| <option name="theme" default="null, inherited from parent" example-value='"b"'> | |||
| <option name="theme" default="inherit" example-value='"b"'> | |||
There was a problem hiding this comment.
The default value really is null.
|
@gabrielschulhof yes, I was wondering because of https://github.com/jquery/jquery-mobile/blob/master/js/widgets/collapsible.js#L353-L364 |
|
@agcolom Bump! |
|
@arschmitz so I should change 'inherit' to 'null' in both cases? |
|
@arschmitz I've changed the defaults for theme and contentTheme to null |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes gh-209