Skip to content

Table review #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gabrielschulhof wants to merge 12 commits into
base: 1-5
Choose a base branch
from
Open

Table review #316

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
491cfb6
Table: Document that the anchor also has to have an ID
May 6, 2014
c5546eb
Table: Document that rebuild() is deprecated in favour of refresh()
May 8, 2014
8ee9cc7
Table: Consolidating extension into a single entry
May 12, 2014
0fc93fc
Table: Make example responsive
May 12, 2014
50721da
Table: Add option "enhanced"
May 12, 2014
4a89b1a
Table: columntoggle does not require an id attribute
May 15, 2014
9e03676
Table: rebuild() will be removed in 1.6.0
May 16, 2014
1158b61
Table: Adding class cellLabelsTop and removing duplicate paragraph
May 16, 2014
2cce782
Table: Document new option columnButton
May 27, 2014
f5d4f3d
Table: Add/Update source extension for classes and options
May 27, 2014
3d862ea
Table: Add classes "cellHidden" and "cellVisible" and method setColum…
May 28, 2014
a26d39c
Table: Copy editing based on review
Jun 5, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Table: Document that the anchor also has to have an ID
  • Loading branch information
Gabriel Schulhof committed Jun 5, 2014
commit 491cfb624d1a75ec46e25940690de4eb6b63ceb8
4 changes: 2 additions & 2 deletions entries/table-columntoggle.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@

<h3>Applying column chooser mode to a table</h3>

<p>The column chooser mode requires a <code>table</code> element with two attributes: <code>data-role=&quot;table&quot;</code> and <code>data-mode=&quot;columntoggle&quot;</code>. An <code>ID</code> attribute is also required on the table to associate it with the column chooser popup menu.</p>
<p>The column chooser mode requires a <code>table</code> element with two attributes: <code>data-role=&quot;table&quot;</code> and <code>data-mode=&quot;columntoggle&quot;</code>. An <code>id</code> attribute is also required on the table to associate it with the column chooser popup menu and the button that launches the popup. The table's <code>id</code> attribute will serve as the prefix for the button's attribute (which will append <code>-button</code> to the previx) nad the popup's attribute (which will append <code>-popup</code> to the prefix).</p>

<pre><code><![CDATA[
<table data-role="table" data-mode="columntoggle" id="my-table">
Expand Down Expand Up @@ -144,7 +144,7 @@
<p>It's fairly common to need to logically group multiple columns together under a heading group for financial or scientific data. The framework can support the most simple version of this by allowing for two rows of table headers (<code>TH</code>), with the first row containing simple <code>colspan</code> attributes to group the columns below. In this configuration, the framework will parse the first row only for the priority and expose these heading groups as the options in the column chooser popup. In this configuration, the second heading will not be exposed as columns that can be hidden or shown independently of the groupings in the chooser. </p>

<xi:include href="../includes/pre-rendered-common.xml" xmlns:xi="http://www.w3.org/2003/XInclude" />
<p>The columntoggle table places an anchor before the table that invokes a popup listing the columns available for showing/hiding. The ID of the popup and thus the href of the anchor should be the ID of the table suffixed by the string <code>-popup</code>. You may separately pre-enhance the popup widget, or you may allow autoinitialization to enhance it.</p>
<p>The columntoggle table places an anchor before the table that invokes a popup listing the columns available for showing/hiding. The ID of the popup and thus the href of the anchor should be the ID of the table suffixed by the string <code>-popup</code>. The anchor must also have an <code>id</code> attribute which is identical to that of the table, but postfixed with <code>-button</code>. This will allow the table to correctly enable/disable when you modify its <code>disabled</code> option. You may separately pre-enhance the popup widget, or you may allow autoinitialization to enhance it.</p>
<p>The popup widget must contain a single controlgroup widget which in turn contains all the checkboxes representing the columns of the table.</p>
<p>In the example below the parameter <code>data-column-btn-theme="b"</code> is added to the table explicitly to indicate that the theme applied to the "Columns..." button is not the default (<code>null</code>).</p>

Expand Down