Panel: Added external panel and enhancement #370
Conversation
| @@ -35,9 +35,36 @@ | |||
| <p>To avoid blinks when opening a panel, we force hardware acceleration on WebKit browsers. The CSS that is used to do this can cause issues with buttons and form elements on the page if their container has a CSS multi-column layout (<code>column-count</code>). To resolve this you have to set the following rule for the element or its container:</p> | |||
|
|
|||
| <pre><code><![CDATA[ | |||
| -webkit-transform: translate3d(0,0,0); | |||
| -webkit-transform: translate3d( 0, 0, 0 ); | |||
There was a problem hiding this comment.
This seems odd we originally used this in panel directly and removed it to fix some issues. We don't use this anywhere else including demos. cc @jaspermdegroot
There was a problem hiding this comment.
@arschmitz should this be removed? (the paragraph to avoid blinks... and the code?) I'm ok to wait for @jaspermdegroot 's reply :-)
There was a problem hiding this comment.
I would prefer to wait for @jaspermdegroot he is the one that worked on all this and knows what happened. I don't remember very well the details
There was a problem hiding this comment.
This seems odd we originally used this in panel directly and removed it to fix some issues.
We still use translate3d() for panel and page wrapper transitions. This note is about a bug that appears when your page contains a CSS columns layout.
We don't use this anywhere else including demos.
Correct, we don't have demo with panels and CSS columns.
This shouldn't be removed unless the bug is fixed in all WebKit browsers/versions that we support.
There was a problem hiding this comment.
@jaspermdegroot Sorry im not sure what i was doing the other day but i searched and could not find use in the repo, but i see it all over the place now. @agcolom feel free to ignore me and leave this sorry!
|
@arschmitz Fixed the spacing :-) |
| <p>The panel can be enhanced manually as follows:</p> | ||
|
|
||
| <pre><code><![CDATA[ | ||
| $( function() { |
There was a problem hiding this comment.
@arschmitz I think I should actually remove the space before function so it goes
$(function() {
Is this correct?
|
@arschmitz I think I've fixed the spacing. It would be great if you could check it's all ok. Thanks :-) |
|
@arschmitz Does this look good to you? Thanks |
|
👍 |
Fixes gh-362