Tap: Added warning about vclick #379
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -7,6 +7,9 @@ | |||
|
|
|||
| <xi:include href="../includes/core-extension-desc.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/> | |||
|
|
|||
| <div class="warning"><h4>Warning: Use tap with caution</h4> | |||
| <p>Tap makes use of vclick and therefore should be used with caution on touch devices. See for the <a href="../vclick/">vclick api documentation</a> for more details</p> | |||
There was a problem hiding this comment.
Misses a period, api => API, and maybe we should change
See for the vclick api documentation for more details
to
See the vclick API documentation for more details
There was a problem hiding this comment.
oh, yes, I changed the text but forgot to remove the beginning! Thanks
|
Looks good to me. |
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes gh-132