Skip to content

Dialog: Extend buttons option docs to cover icons or other button widget options #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
jzaefferer opened this issue Jun 19, 2014 · 1 comment

Comments

@jzaefferer
Copy link
Member

Currently the docs don't tell how to use icons with the buttons option. The relevant part of the implementation in dialog:

buttonOptions = {
    icons: props.icons,
    text: props.showText
};
delete props.icons;
delete props.showText;
$( "<button></button>", props )
    .button( buttonOptions )
    .appendTo( that.uiButtonSet );

In addition, the default for the buttons option is wrong, its an empty array.

@tjvantoll
Copy link
Member

I fixed the default value of buttons.

scottgonzalez added a commit to scottgonzalez/api.jqueryui.com that referenced this issue Nov 3, 2014
scottgonzalez added a commit to scottgonzalez/api.jqueryui.com that referenced this issue Nov 6, 2014
scottgonzalez added a commit that referenced this issue Jan 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging a pull request may close this issue.

2 participants