Check size of all demo frames with theme updates

[scottgonzalez]

With the new theme and font size, we should go through all pages to make sure the demo frames are tall enough to show the full demo.

[jzaefferer]

Let's do this once the theme update is in master, that should make it a bit easier.

[arschmitz]

May want to wait until button lands, too, since it changes quite a few of the demos in some way.

[scottgonzalez]

I suppose it times to finally do this ;-) Any takers?

[agcolom]

@scottgonzalez I'm happy to do this... Is it just about checking the demos fit in their frame?
Should we also check the frames at the bottom of the examples in the api docs pages?
How do you want to proceed?

[scottgonzalez]

@scottgonzalez I'm happy to do this...

Wonderful! 👍

Is it just about checking the demos fit in their frame?

Yup. Specifically on the 1.12 site: http://api.jqueryui.com/1.12/

Should we also check the frames at the bottom of the examples in the api docs pages?

Those are actually the only demo frames that exist. We don't have inline demos like api.jquerymobile.com, so this is actually a fairly quick task.

How do you want to proceed?

Just go through the demos and either leave a comment here with any that aren't a good size or send a PR that updates their heights.

Thanks.

[agcolom]

@scottgonzalez Brilliant.

Also, how about these demos: (I thought these were the ones you meant): http://jqueryui.com/demos/, so http://jqueryui.com/accordion/, etc...

[agcolom]

@scottgonzalez These examples are still using UI 1.11.4. Will you update to 1.12beta? Or should I check the examples locally?

[scottgonzalez]

This is only about api.jqueryui.com.

[agcolom]

Yes, but currently is using 1.11.4:
http://api.jqueryui.com/1.12/accordion/#entry-examples (Or am I looking at the wrong place?)

[scottgonzalez]

Oh, yeah, we never updated that. Releasing the API docs during pre-releases is new, so I didn't have a checklist to work from. I'll get that updated and add it to the checklist. Thanks :-)

[agcolom]

Perfect :-) I'll get started when that's done :-)

[scottgonzalez]

You can now test on http://stage.api.jqueryui.com/1.12/.

[agcolom]

Thank you will start checking now (I have 20min before I need to go)

[agcolom]

I'll add notes here, so we know what's been done/not done:

• widgets: All checked
  • selectmenu: 250, 250, 250 -> 250, 260, 265 (3 frames)
  • tooltip: 80 -> 100
• theming: all checked
  • icons: 1000 -> 1650 if you want to avoid scrolling.
• effects:
  • easing: change frame containing easing-graph.html 600 -> 960 if you want to avoid scrolling.
• effects core: all ok
• interactions: all ok
• methods: all ok
• method overrides:
  • position: 300 -> 305
• selectors: all ok
• ui core: all ok
• utilities: all ok

[agcolom]

@scottgonzalez All done :-) Icons and easing are not crucial but I checked the size in case you wanted to avoid scrolling there as well.

[scottgonzalez]

Wonderful. Thanks.

[scottgonzalez]

Fixed in 18b4814.