Greedy clarification #107
Closed
Greedy clarification #107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think this wording is confusing as well. It makes it sound like we're explicitly firing the event on the parents. We probably shouldn't mention callback and event as separate things. Just say that the event will bubble up to the parents, and you can check |
|
Landed in 64070f2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The description was a little ambiguous. With current documentation, I did not expect parent should have fired
console.login this example: http://jsfiddle.net/pe62d/2/I was assuming the event bubble was being stopped within the widget. I'm not too sure my wording of "via the callback method" is the greatest either. Let me know what you think