jquery.widget: Breaking up the initialization section into initializatio... #127
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion/options sections and adding information on the default option values and how they can be changed. Fixes jquery#126.
|
Looks good to me. |
|
Looks good, but I'd add a sentence to clarify that changing the default will affect all instances created in the future. |
…defaults applies to future instances.
|
@scottgonzalez Switched a sentence up to clarify in tjvantoll@47b94f7. Rebased and landed in 821946a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...n/options sections and adding information on the default option values and how they can be changed. Fixes #126.