Skip to content

Porting CSS class name docs from the old site and placing it in a new th... #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from

Conversation

tjvantoll
Copy link
Member

...eming category. Fixes #59: Document CSS

I made up type="basic" so there might be a better of handling that. I made this an entry rather than a page because I thought theming deserved its own category and listing in the sidebar. Otherwise I think this content will be hidden.

The content itself is mostly the same as the old site but I altered it a bit.

@scottgonzalez
Copy link
Member

We should keep it as a page. We can add a custom field to indiciate that it should be included in the sidebar.

<code>.ui-helper-clearfix</code>: Applies float wrapping properties to parent elements.
</li>
<li>
<code>.ui-helper-zfix</code>: Applies iframe "fix" css to iframe elements when needed in overlays.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had no idea this thing existed. We should remove it.

@scottgonzalez
Copy link
Member

I did a quick review of this. I'll do another pass after the updates. Thanks :-)

@tjvantoll
Copy link
Member Author

Changes from your review are here: bbb1e6d. I also added .ui-front here eeaddd6.

As discussed in IRC, the Theming category does not display in the sidebar. So the page is only accessible via direct access.

@scottgonzalez
Copy link
Member

I'm going to try to get the page to show up in the sidebar, then I'll do a second pass on this content.

@tjvantoll
Copy link
Member Author

Landed in 214280e.

@tjvantoll tjvantoll closed this May 18, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Document CSS
2 participants