Skip to content

Conversation

@jzaefferer
Copy link
Member

...gger: Return value undocumented

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

false is in <code> blocks on the first usage but not the second.

@tjvantoll
Copy link
Member

Can't _trigger invoke multiple callbacks? This isn't necessarily related to your change; all the docs for this method seem to think there's one callback.

@scottgonzalez
Copy link
Member

There can be many event handlers, but only one callback. The callback is provided by an option. Other than the one formatting issue @tjvantoll pointed out, this looks good to me.

@scottgonzalez
Copy link
Member

Actually, to avoid the confusion, and describe the behavior more semantically, perhaps something like "If the default action is prevented..." or "The return value indicates whether the default action should take place."

@jzaefferer
Copy link
Member Author

I've updated this, rewording the description as suggested.

@scottgonzalez
Copy link
Member

Looks good.

@tjvantoll
Copy link
Member

+1

@jzaefferer jzaefferer merged commit f5c50dd into master Sep 6, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants