Widget: Document how options are handled on init (deep copy except array... #174
Conversation
entries/jQuery.widget.xml
Outdated
There was a problem hiding this comment.
"The only exception are arrays"
There's a plurality mismatch here. Either "The only exception is arrays" or "Arrays are the only exception."
There was a problem hiding this comment.
This exceptions is => This exception is
There was a problem hiding this comment.
I don't think we should say "potentially huge". While performance is certainly an issue for large data sources, we need to keep the reference to the actual items regardless of the size. I believe we made this change when working with small data sources because we needed data binding to stay in tact.
There was a problem hiding this comment.
Minor grammatical suggestions.
"All options passed on init are deep-copied, to ensure the objects can be modified later without affecting the widget." (drop the comma)
"The only exception are arrays, those are just referenced as-is." --> "The only exception are arrays, which are referenced as-is."
This looks fine to me.
|
Updated |
|
Looks good. |
|
+1 |
...s). Fixes #159