-
Notifications
You must be signed in to change notification settings - Fork 75
Documenting Extension Points. Fixes #20. #178
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This one is looking good. May need to update once anchors are gone from menu, but that would go into the 1-11 branch anyway. |
…the <a> tag requirement in a note so it's easily axed in 1.11 when the requirement is dropped.
I made the recommended changes to |
Ok, I discovered this after I moved onto the next method. Although you can use any element for menu items, it's silly to use anything other than I'm thinking we should just stick with the |
Yeah, sounds good. I forgot that we didn't design autocomplete to be super flexible in terms of markup since the |
@scottgonzalez @jzaefferer @kborchers ping. These should be good to go if you want to take a look. Here are screenshots so you don't have to sift through XML. |
Looks good to me. |
👍 |
1 similar comment
👍 |
It'll probably take me another day or two to make my way through these. I'll ping people when this is ready for review.