Skip to content

Documenting Extension Points. Fixes #20. #178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from

Conversation

tjvantoll
Copy link
Member

It'll probably take me another day or two to make my way through these. I'll ping people when this is ready for review.

@jzaefferer
Copy link
Member

This one is looking good. May need to update once anchors are gone from menu, but that would go into the 1-11 branch anyway.

…the <a> tag requirement in a note so it's easily axed in 1.11 when the requirement is dropped.
@tjvantoll
Copy link
Member Author

I made the recommended changes to _renderItem. The <a> requirement is in its own paragraph now so it's easily axed when that requirement is removed.

@tjvantoll
Copy link
Member Author

Ok, I discovered this after I moved onto the next method. Although you can use any element for menu items, it's silly to use anything other than <li> elements because the menu itself is created as a <ul> in the middle of an epic (aka not feasibly overridable) _create() method.

I'm thinking we should just stick with the ul parameter and <ul> element in the docs for _renderItem since you will actually be getting a <ul>. Thoughts?

@scottgonzalez
Copy link
Member

Yeah, sounds good. I forgot that we didn't design autocomplete to be super flexible in terms of markup since the <ul>/<li> combo allows for a decent amount of customization within the items.

@tjvantoll
Copy link
Member Author

@scottgonzalez @jzaefferer @kborchers ping. These should be good to go if you want to take a look. Here are screenshots so you don't have to sift through XML.

screen shot 2013-09-26 at 9 04 40 am
screen shot 2013-09-26 at 9 04 54 am
screen shot 2013-09-26 at 9 05 05 am
screen shot 2013-09-26 at 9 05 10 am
screen shot 2013-09-26 at 9 05 20 am

@scottgonzalez
Copy link
Member

Looks good to me.

@kborchers
Copy link
Member

👍

1 similar comment
@jzaefferer
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

4 participants