Skip to content

Conversation

@scottgonzalez
Copy link
Member

Does this seem good enough or is there more that we should write?

I'm not thrilled about using the warning class to get the styling, but we could always just add a note class which has the same styling for now just so that we're not abusing classes.

@tjvantoll
Copy link
Member

The wording seems fine to me.

I agree that, in general, we need a tip or note type class name to handle tangental notes like this. It would be nice to have on the learn site itself, as it currently uses a format like this:

screen shot 2014-03-27 at 4 30 13 pm
(For example see here and here)

Maybe change the background to blue for notes?

.note {
    padding: 0.5em 1em;
    margin: 1em;
    background: #428bca;
    color: white;
    border-radius: 5px;
}
.note a {
    color: white;
}

screen shot 2014-03-27 at 4 30 05 pm

I'm fine with whatever though. As long as we create and use the class name we can let someone with design talent make it pretty.

scottgonzalez added a commit to jquery/jquery-wp-content that referenced this pull request Apr 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants