Menu: Document the new wrapper requirement #239
Conversation
| @@ -46,9 +61,13 @@ | |||
|
|
|||
There was a problem hiding this comment.
Not part of the diff, but it says "unlinked menu items" on the line above (or so), which probably made sense back when we were using <a> elements as wrappers.
|
Also a "while we're here": For the focus method, the description is missing a "by" (I think), currently it reads "Activates a particular menu item, begins opening any sub-menu if present" Otherwise looks good. |
a70c4e4 to
4886ed4
Compare
|
Good catches @jzaefferer. I pushed changes to the two things you found. |
|
Looks good. |
|
@jzaefferer Does that mean @tjvantoll can land this PR? |
|
Yes, unless someone else wants to review it as well. |
|
@scottgonzalez can you take (another) look at this? Should be good to land as well. |
|
Looks good. |
|
Just merged, but GitHub doesn't close this PR: dd2629f What am I missing? |
|
Commits to branches don't close issues or PRs. |
|
Right, I guess it worked for #243 because it was a merge. |
Fixes gh-234