-
Notifications
You must be signed in to change notification settings - Fork 75
Update dialog.xml #240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dialog.xml #240
Conversation
Diction regarding the focus state
Can you explain why this is better? |
They seem different, is the new verbiage accurate? Does the dialog in fact prevent (for example) screen reader navigation beyond the boundaries of the dialog? |
It was an edit solely for clarity -- not to change meaning. Reasoning: I initially read the phrase "tabbing cycles" as a compound noun, and the word "focus" as a verb. @dylanb : I can't speak specifically to screen reader navigation, but dialog does in fact successfully prevent traditional keyboard navigation from focusing on elements beyond its boundaries. |
perhaps "keyboard navigation using the 'tab' key, causes the focus to cycle amongst the focusable elements in the dialog..."? |
Yeah, that'll work too. |
@scottgonzalez you ok with that? |
yup |
@mattbrundage you want to make that change to your PR? |
Modified diction, as suggested by @dylanb
@scottgonzalez Are you happy with the PR? |
Yes, this looks good. Can you please sign the CLA? |
Signed. |
Diction regarding the focus state