-
Notifications
You must be signed in to change notification settings - Fork 75
Effects: Mark transfer-effect deprecated, document .transfer() #263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
<property name="className" type="String" default="null"> | ||
<desc>A class to add to the transfer element, in addition to <code>ui-effects-transfer</code>.</desc> | ||
</property> | ||
<property name="duration" type="Number" default="400"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You only got part of this; there are two types. It's also optional, not sure if we support that for properties...
Some minor changes, but it looks good. The |
Updated |
Merged 2af9f44 into |
Ref gh-242
First commit to document the effects rewrite, more to come.