Effects: Mark transfer-effect deprecated, document .transfer() #263
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <property name="className" type="String" default="null"> | ||
| <desc>A class to add to the transfer element, in addition to <code>ui-effects-transfer</code>.</desc> | ||
| </property> | ||
| <property name="duration" type="Number" default="400"> |
There was a problem hiding this comment.
There was a problem hiding this comment.
You only got part of this; there are two types. It's also optional, not sure if we support that for properties...
|
Some minor changes, but it looks good. The |
|
Updated |
jzaefferer
added a commit
that referenced
this pull request
Apr 22, 2015
|
Merged 2af9f44 into |
jzaefferer
added a commit
that referenced
this pull request
May 7, 2015
jzaefferer
added a commit
that referenced
this pull request
Sep 30, 2015
jzaefferer
added a commit
that referenced
this pull request
Oct 28, 2015
jzaefferer
added a commit
that referenced
this pull request
Oct 29, 2015
jzaefferer
added a commit
that referenced
this pull request
Dec 17, 2015
jzaefferer
added a commit
that referenced
this pull request
Jul 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref gh-242
First commit to document the effects rewrite, more to come.