Skip to content

Effects: Mark transfer-effect deprecated, document .transfer() #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

jzaefferer
Copy link
Member

Ref gh-242

First commit to document the effects rewrite, more to come.

<property name="className" type="String" default="null">
<desc>A class to add to the transfer element, in addition to <code>ui-effects-transfer</code>.</desc>
</property>
<property name="duration" type="Number" default="400">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You only got part of this; there are two types. It's also optional, not sure if we support that for properties...

@scottgonzalez
Copy link
Member

Some minor changes, but it looks good. The .transfer() method itself has a bug though :-/ http://bugs.jqueryui.com/ticket/12223 I'll work on that today.

@jzaefferer
Copy link
Member Author

Updated

@jzaefferer
Copy link
Member Author

Merged 2af9f44 into 1-12 branch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants