Skip to content

Effects rewrite #267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 24, 2015
Merged

Effects rewrite #267

merged 2 commits into from
Apr 24, 2015

Conversation

jzaefferer
Copy link
Member

Addresses some more of #242.

scottgonzalez
scottgonzalez reviewed Apr 24, 2015
View reviewed changes
entries/cssClip.xml
<?xml version="1.0"?>
<entry name="cssClip" type="method" return="jQuery">
<title>.cssClip()</title>
<desc>getter/setter for an object version of the CSS <code>clip</code> property</desc>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Start with a capital letter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

End with a period.

@jzaefferer
Copy link
Member Author

Addressed everything. Added to both "effects" and "effects-core" categories.

@scottgonzalez
Copy link
Member

Looks good.

@jzaefferer
Entries: Document cssClip method
ad2996b 
Includes example for animating clip, adds <added> entry for transfer
method.

Ref gh-242
Closes gh-267
@jzaefferer jzaefferer merged commit ad2996b into 1-12 Apr 24, 2015
@jzaefferer jzaefferer deleted the effects-rewrite branch April 24, 2015 21:48
jzaefferer added a commit that referenced this pull request May 7, 2015
@jzaefferer
Entries: Document cssClip method
95ac547 
Includes example for animating clip, adds <added> entry for transfer
method.

Ref gh-242
Closes gh-267
jzaefferer added a commit that referenced this pull request Sep 30, 2015
@jzaefferer
Entries: Document cssClip method
40dbbb1 
Includes example for animating clip, adds <added> entry for transfer
method.

Ref gh-242
Closes gh-267
jzaefferer added a commit that referenced this pull request Oct 28, 2015
@jzaefferer
Entries: Document cssClip method
168f159 
Includes example for animating clip, adds <added> entry for transfer
method.

Ref gh-242
Closes gh-267
jzaefferer added a commit that referenced this pull request Oct 29, 2015
@jzaefferer
Entries: Document cssClip method
cd410a9 
Includes example for animating clip, adds <added> entry for transfer
method.

Ref gh-242
Closes gh-267
jzaefferer added a commit that referenced this pull request Dec 17, 2015
@jzaefferer @scottgonzalez
Entries: Document cssClip method
e59e812 
Includes example for animating clip, adds <added> entry for transfer
method.

Ref gh-242
Closes gh-267
jzaefferer added a commit that referenced this pull request Jul 8, 2016
@jzaefferer
Entries: Document cssClip method
dee221c 
Includes example for animating clip, adds <added> entry for transfer
method.

Ref gh-242
Closes gh-267
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jzaefferer @scottgonzalez @jquerybot