Skip to content

Animation: Clarify that complete callback is per element #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Animation: Clarify that complete callback is per element
Fixes gh-291
  • Loading branch information
scottgonzalez committed Dec 2, 2015
commit ef3c6afb415c3c0dea56f291c761707275a6ea8f
2 changes: 1 addition & 1 deletion includes/animation-argument-complete.xml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<?xml version="1.0"?>
<argument name="complete" type="Function" optional="true">
<desc>A function to call once the animation is complete.</desc>
<desc>A function to call once the animation is complete, called once per matched element.</desc>
</argument>
2 changes: 1 addition & 1 deletion includes/animation-signature-options.xml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
</type>
</property>
<property name="complete" type="Function">
<desc>A function to call once the animation is complete.</desc>
<desc>A function to call once the animation is complete, called once per matched element.</desc>
</property>
<property name="queue" default="true">
<type name="Boolean"/>
Expand Down
2 changes: 1 addition & 1 deletion includes/class-animation-argument-options.xml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
<desc>A string indicating which <a href="/easings/">easing</a> function to use for the transition.</desc>
</property>
<property name="complete" type="Function" optional="true">
<desc>A function to call once the animation is complete.</desc>
<desc>A function to call once the animation is complete, called once per matched element.</desc>
</property>
<property name="children" type="Boolean" default="false">
<desc>Whether the animation should additionally be applied to all descendants of the matched elements. This feature should be used with caution as the cost of determining which descendants to animate can be very expensive, and grows linearly with the number of descendants.</desc>
Expand Down