Skip to content

Conversation

@OmgImAlexis
Copy link

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only .json file that uses spaces is package.json. Every other file uses tabs.

@scottgonzalez
Copy link
Member

When adding a file like this, you should attempt to apply the rules to the existing codebase. That will give you an idea if the rules you're putting in place actually make sense for the project.

@scottgonzalez
Copy link
Member

Why did you close all of your PRs?

@OmgImAlexis
Copy link
Author

@scottgonzalez I'll just wait till you guys have your repos worked out. There's no point in keeping them open when I can't even merge them as you guys haven't added an editorconfig or anything similar to keep whitespace setup correctly. I would have figured from an organisation as big as jQuery these things would have been worked out years ago.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants