Skip to content

Controlgroup: Small fixes to entry #298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Controlgroup: Small fixes to entry #298

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5ea7106
Controlgroup: Small fixes to entry
agcolom Mar 21, 2016
4bb4881
Controlgroup: Additions based on PR comments
agcolom Apr 14, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Controlgroup: Small fixes to entry
  • Loading branch information
@agcolom
agcolom committed Mar 21, 2016
commit 5ea7106159ec99bbec349d74b868ef18f1afea6a
8 changes: 4 additions & 4 deletions entries/controlgroup.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,15 @@
<xi:include href="../includes/classes-option-desc.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>
<xi:include href="../includes/classes-option-example.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>
</option>
<option name="direction" default='"horizontal"' example-value='{ direction: "vertical" }'>
<option name="direction" default='"horizontal"' example-value='"vertical"'>
<desc>
<p>By default, controlgroup displays its widget's in a horizontal layout. Use this option to use a vertical layout instead.</p>
<p>By default, controlgroup displays its controls in a horizontal layout. Use this option to use a vertical layout instead.</p>
</desc>
<type name="String" />
</option>
<xi:include href="../includes/widget-option-disabled.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/>
<option name="onlyVisible" default="true" example-value="false">
<desc>Sets whether to exclude invisible children in the assignment of rounded corners. When set to false, all children of a controlgroup are taken into account when assigning rounded corners, including hidden children. Thus, if, for example, the controlgroup's first child is hidden, the controlgroup will, in effect, not have rounded corners on the top edge.</desc>
<desc>Sets whether to exclude invisible children in the assignment of rounded corners. When set to false, all children of a controlgroup are taken into account when assigning rounded corners, including hidden children. Thus, if, for example, the controlgroup's first child is hidden, the controlgroup will, in effect, not have rounded corners on the left edge.</desc>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense for the default direction. Could be made explicit though, something like "not have rounded corners on the left edge (for direction: "horizontal")."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how about this (Added text in bold): "Sets whether to exclude invisible children in the assignment of rounded corners. When set to false, all children of a controlgroup are taken into account when assigning rounded corners, including hidden children. Thus, if, for example, the controlgroup's first child is hidden and the default horizontal layout is applied, the controlgroup will, in effect, not have rounded corners on the left edge."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also have an additional sentence after this to say: "Likewise, if the controlgroup has a vertical layout and its first child is hidden, the controlgroup will not have rounded corners on the top edge."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both additions sound good to me.

<type name="Boolean" />
</option>
<option name="items">
Expand All @@ -51,7 +51,7 @@
"spinner": ".ui-spinner-input"
}</default>
<desc>
Which descendant elements to initialize as their respective widgets. Two elements have special behaviour:
Which descendant elements to initialize as their respective widgets. Two elements have special behavior:
<ul>
<li><code>controlgroupLabel</code>: Any elements matching the selector for this will be wrapped in a span with the <code>ui-controlgroup-label-contents</code> class.</li>
<li><code>spinner</code>: This uses a class selector as the value. Requires either adding the class manually or initializing the spinner manually. Can be overridden to use <code>input[type=number]</code>, but that also requires custom CSS to remove the native number controls.</li>
Expand Down