Selectmenu: Fix examples for classes option
#313
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Ideally we could just define which class to use in the include. Fixes jquery/jqueryui.com#161
5dc7db4 to
e6cf7dc
Compare
jzaefferer
approved these changes
Feb 21, 2017
| <xi:include href="../includes/classes-option-example.xml" xmlns:xi="http://www.w3.org/2003/XInclude"/> | ||
| <examples> | ||
| <example> | ||
| <desc>Initialize the <placeholder name="name"/> with the <code>classes</code> option specified, changing the theming for the <code>ui-selectmenu-menu</code> class:</desc> |
There was a problem hiding this comment.
Don't need the <placeholder name="name"/> here, could instead inline selectmenu. That's used a few more times below.
There was a problem hiding this comment.
I left it so the diff to the include is as small as possible.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we could just define which class to use in the include.
Fixes jquery/jqueryui.com#161