Skip to content

All: add CSP exceptions for remote images #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

All: add CSP exceptions for remote images #10

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion jquery/functions.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,8 +293,10 @@ function twentyeleven_content_security_policy() {
'script-src' => "'self' 'unsafe-inline' code.jquery.com use.typekit.net",
// Allow inline styles for typekit
'style-src' => "'self' 'unsafe-inline' code.jquery.com",
// Allow images from about:blank, *.cloudfront.net, events.jquery.org, and openjsf.org
// Allow images from *.twimg.com, gruntjs.com and *.imgur.com
// Leaving out typekit img-src, which only loads the p.gif for analytics
'img-src' => "'self' code.jquery.com",
'img-src' => "'self' about: *.cloudfront.net events.jquery.org openjsf.org *.twimg.com gruntjs.com *.imgur.com code.jquery.com",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's okay with you, I'd like to import and self-host into the blog these images.

At least the ones from imgur.com and twimg.com (which are prone to deletion these days). I'd backfill from Internet Archive for any that are already gone.

Feel free to roll this out as-is either way, we can reduce it later.

// Allow fonts from typekit
'font-src' => "'self' use.typekit.net",
'object-src' => "'none'",
Expand Down