Improve dependency parsing (ignore comments, simplify function)#1
Closed
jzaefferer wants to merge 1 commit intojquery:masterfrom
Closed
Improve dependency parsing (ignore comments, simplify function)#1jzaefferer wants to merge 1 commit intojquery:masterfrom
jzaefferer wants to merge 1 commit intojquery:masterfrom
Conversation
Member
Author
There was a problem hiding this comment.
This passes as-is, but I don't think it should. Since input.js depends on version.js, their respective CSS should reflect that dependency, so this expect should be equal to "body {}\ninput {}\n"
@arschmitz @rxaviers thoughts?
Member
Author
There was a problem hiding this comment.
I've discussed this with @arschmitz and filed #2 to address this later. This PR should be good to land.
Member
|
Please, could you sign-off your commit? |
index.js
Outdated
Member
There was a problem hiding this comment.
spaces replace(/\/\/.+/g, "").
b4cfdb5 to
033d042
Compare
Adds tests for nested modules and defines with line comments inside. Signed-off-by: Jörn Zaefferer <joern.zaefferer@gmail.com>
033d042 to
3a0bbca
Compare
Member
Author
|
Updated. Addressed all comments. |
Member
|
Merged, released on 0.0.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds tests for nested modules and defines with line comments inside.