Skip to content

Build: Enable sri-modal links for qunit releases #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
trentmwillis merged 2 commits into from
Aug 25, 2018
Merged

Build: Enable sri-modal links for qunit releases #41

trentmwillis merged 2 commits into from
Aug 25, 2018

Conversation

@Krinkle
Copy link
Member

@Krinkle Krinkle commented Aug 25, 2018

Ref #39.

Krinkle added 2 commits August 25, 2018 02:47
@Krinkle
Build: Only require config.json for the "deploy" task
4fd831c 
This makes the other tasks also usable locally, given they
don't use the wordpress config. In prep for fixing issue jquery#40.
@Krinkle
Build: Enable sri-modal links for qunit releases
7d89e9c 
Fixes jquery#39.
trentmwillis
trentmwillis reviewed Aug 25, 2018
View reviewed changes
Copy link
Member

@trentmwillis trentmwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not familiar with the code, but I'm 👍 on the idea!

@Krinkle
Copy link
Member Author

Krinkle commented Aug 25, 2018

To test locally, run grunt build and check that the HTML file for qunit now follows a similar style for its anchor links as the index and jquery files.

@trentmwillis I don't actually have push on this repository. Could you land it?

trentmwillis
trentmwillis approved these changes Aug 25, 2018
View reviewed changes
Copy link
Member

@trentmwillis trentmwillis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup the local dev environment and tested out the changes. Looks good. I'll land.

@trentmwillis trentmwillis merged commit 6e82c21 into jquery:master Aug 25, 2018
@Krinkle Krinkle deleted the sri-qunit branch August 25, 2018 23:53
Krinkle added a commit that referenced this pull request Jul 7, 2023
@Krinkle
qunit: Fix stylesheet link to not put up JS dialog
84911b5 
It would be nice to support `<link>` in this dialog, as requested
in #71, but right
now the dialog suggests `<script>` for the stylesheet which is wrong.

This only affected QUnit, in which I mistakenly wrote it this way
since commit 6e82c21 in 2018.

Ref #41.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@trentmwillis trentmwillis trentmwillis approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@Krinkle @trentmwillis