Build: Improve docs around config.json file #42
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two versions of this file on different jq servers internally, one with just the wp stuff, one with just the cdn stuff. Update the sample file to match the keys that exist in reality. Specifically, the sample was missing the 'zone_id' field that we were already depending on in purge.php. The sample was also missing the 'alias' field that we set in production. Make use of this field instead of hardcoding "jquery" so that things are easier to update quickly when needed.
|
Combined with #44 for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two versions of this file on different jq servers internally,
one with just the wp stuff, one with just the cdn stuff.
Update the sample file to match the keys that exist in reality.
Specifically, the sample was missing the 'zone_id' field that
we were already depending on in purge.php.
The sample was also missing the 'alias' field that we
set in production. Make use of this field instead of hardcoding
"jquery" so that things are easier to update quickly when needed.