purge: Fix CDN purge script (enable purgeAllDynamic option)
#48
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While not yet documented or announced, it seems the Purge API from StackPath/Highwinds/StrikeTracker no longer purges variants by default as of last month. The old behaviour can be regained through the undocumented `purgeAllDynamic` boolean option which appears to be false by default. I'm not sure what variants we have that cause this behaviour, but it might be due to something like Vary:Accepted-Encoding (gzip etc.). Fixes jquery#45.
|
I've confirmed locally that Previously, the CDN url still showing jQuery Mobile 1.5.0-alpha.1. |
|
@Krinkle Thank you so much there have been tons of people complaining about it not existing |
|
@Krinkle I added you to the maintainers team so you can land this whenever you feel good about it. Thanks! |
|
Thanks @dmethvin. I'll try it out now and will revert if not working as expected. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While not yet documented or announced, it seems the Purge API
from StackPath/Highwinds/StrikeTracker no longer purges variants
by default as of October this year.
The old behaviour can be regained through the undocumented
purgeAllDynamicboolean option which appears to be falseby default.
I'm not sure what variants we have that cause this behaviour, but
it might be due to something like Vary:Accepted-Encoding (gzip etc.).
Fixes #45.