Build: Prepare for releases.jquery.com #70
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brianwarner
approved these changes
Jan 22, 2021
Krinkle
approved these changes
Jan 22, 2021
1. Point CDN links directly to https://code.jquery.com. 2. Add a separate helper for non-SRI CDN links. This is mostly used for CSS which, in theory, could also have SRI applied but that would require changes to the SRI plugin so we're leaving CSS without SRI for now. 3. Git files are now served from the `/git/` directory. 4. Add config-sample.json with the new required cdn_origin field.
2db2559 to
476e9ef
Compare
Krinkle
pushed a commit
that referenced
this pull request
Feb 28, 2021
This is a backport of commit 2485653 from #70 > 1. Point CDN links directly to https://code.jquery.com. > 2. Add a separate helper for non-SRI CDN links. This is mostly used for CSS > which, in theory, could also have SRI applied but that would require changes to > the SRI plugin so we're leaving CSS without SRI for now. > 3. Add config-sample.json with the new required cdn_origin field. > Defined in infra as of jquery/infrastructure@ffa44e60b4. Differences: * The change to use a `/git` directory for Git files was not included in this backport, as doing so would break the current code.jquery.com site. We can either take the two lines of Nginx config from the new releases-jq site and apply to the old codeorigin-jq in Puppet first, and thus use /git/ on both sites before the transition starts; or we can instead apply the old Nginx config for the top-level files also to releases-jq and perform the adoption of /git/ in the WordPress pages after the transition. Either way could work. For now, in the name of progress, this commit does neither. It backports the known-safe part of the prep commit so that we can deploy and verify the 'cdn_origin' config option, and the other template changes made by this commit.
Krinkle
pushed a commit
that referenced
this pull request
Mar 7, 2021
Git files are now served from the `/git/` directory. Support for this was added on the server in the private commit at jquery/infrastructure@aeae9f8728b. This is in preparation for a new browser at releases.jquery.com, and that server will only support `/git/` for these files. The codeorigin server will supporting both the top-level access and /git/ access, by making them redirect to releases.jquery.com. Ref #70.
Krinkle
pushed a commit
that referenced
this pull request
Mar 7, 2021
Git files are now served from the `/git/` directory. Support for this was added on the server in the private commit at jquery/infrastructure@aeae9f8728b. This is in preparation for a new browser at releases.jquery.com, and that server will only support `/git/` for these files. The codeorigin server will supporting both the top-level access and /git/ access, by making them redirect to releases.jquery.com. Ref #70.
Krinkle
added a commit
that referenced
this pull request
Mar 8, 2021
Git files are now served from the `/git/` directory. Support for this was added on the server in the private commit at jquery/infrastructure@aeae9f8728b. This is in preparation for a new browser at releases.jquery.com, and that server will only support `/git/` for these files. The codeorigin server will supporting both the top-level access and /git/ access, by making them redirect to releases.jquery.com. Ref #70. Co-authored-by: Michał Gołębiowski-Owczarek <m.goleb@gmail.com>
Krinkle
added a commit
to jquery/jquery-wp-content
that referenced
this pull request
Aug 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which, in theory, could also have SRI applied but that would require changes to
the SRI plugin so we're leaving CSS without SRI for now.
/git/directory.