Publish machine-readable file list and SRI data to resources/ #76
Conversation
|
This is mainly to help me implement a "Verify reproducible builds" job in CI for QUnit, for which I'd otherwise need to either guess at filenames or scrape HTML (ref qunitjs/qunit#1560). |
| // This copies /resources/* to /dist/wordpress/resources/*, | ||
| // This is flattened (subpaths not preserved) to just base filenames, |
There was a problem hiding this comment.
Are we sure we're OK with exposing all these files? I'm not sure what else is there.
There was a problem hiding this comment.
Internally, the build currently results in an empty ./dist/wordpress/resources directory for codeorigin. Although even if it wasn't empty, this patch is not enabling it as a feature (it is always on).
The build-resources task is poorly named, as all it does is copy the local files in ./resources/ to local ./dist/wordpress/resources. We could instead generate the two JSON files directly in ./dist/wordpress/resources and not need this task.
The task of uploading the contents of ./dist/wordpress/resources is separate from this and is always enabled for all WP sites.
This is the same, simpler, approach as utilised at <https://github.com/jquery/api.jquery.com/blob/v3.1.0/Gruntfile.js>.
Let "wordpress-deploy" upload this to the site, which the gw-resources plugin exposes via addresses like <https://releases.jquery.com/resources/foo>. See <https://github.com/jquery/api.jquery.com/> for an example of this. Local test plan: ``` nobody$ npm ci nobody$ cp config-sample.json config.json nobody$ ./node_modules/.bin/grunt sri nobody$ less resources/sri-directives.json {"@cdn/color/2.2.0/jquery.color.js":{"hashes":{"sha256":"gvMJWDH... nobody$ ./node_modules/.bin/grunt build-index build-resources nobody$ less dist/wordpress/resources/sri-directives.json {"@cdn/color/2.2.0/jquery.color.js":{"hashes":{"sha256":"gvMJWDH... nobody$ less dist/wordpress/resources/cdn.json { "jquery": [ [ "3", { "latestStable": { "filename": "jquery-3.6.0.js", ... ``` Closes #40.
Let "wordpress-deploy" upload this to the site, which the gw-resources plugin exposes via addresses like https://releases.jquery.com/resources/foo.
See https://github.com/jquery/api.jquery.com/ for an example of this.
Local test plan:
Closes #40.