-
Notifications
You must be signed in to change notification settings - Fork 74
JS Style Guide: Fix full file closures #106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👍 Could use the opportunity to add an example for node, e.g. a var path = require( "path" );
module.exports = function( grunt ) {
grunt.registerTask( "custom task", function() {
// task impl
} );
}; |
Added. |
``` | ||
|
||
``` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing js
language instruction
Looking good 👍 |
// This doesn't get indented | ||
|
||
}; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also missing closing backticks, messing up the highlighting of the remaining file...
Good to land. |
No description provided.