Skip to content

Websites: Clarify deploy and tag stage #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Websites: Clarify deploy and tag stage #119

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f146b16
Websites: Clarify deploy and tag stage
agcolom May 3, 2015
79a2dc9
Websites: Replaced md inside html block with html
agcolom May 3, 2015
d071cf2
Website: Reword according to feedback
agcolom May 3, 2015
88053ef
Website: Only use html in html block
agcolom May 3, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions pages/web-sites.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,8 +120,14 @@ For other sites:

To create a tag, use `npm version [major | minor | patch]`.

Afterwards, make sure to push both version change commit and the tag:
`git push --tags origin master`
Afterwards, make sure to push both version change commit and the tag to the main jQuery repo.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this change is necessary, especially with the warning included.


<div class="warning">You'll want to check your remote setup using <code>git remote -v</code> and check which remote is used for the main jQuery repo.</div>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps:

The example below uses upstream for the jQuery organization on GitHub. Use git remote -v to ensure you're pushing to the correct remote repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And then drop the condition below.


If `upstream` is the remote you use for that, type:
`git push --tags upstream master`

If you use `origin` for the main jQuery repo, replace `upstream` with `origin` in the command above.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I personally don't like the words "main jQuery repo."

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I probably should've read the whole thing before I started commenting. Perhaps take my suggested wording and move it down here, replacing "below" and "above" and adding this sentence. That would give you:

The example above uses upstream for the repo in the jQuery organization on GitHub. Use git remote -v to ensure that you're pushing to the correct remote repo. For example, If you use origin for the repo in the jQuery organization, replace upstream with origin.


---

Expand Down