Skip to content

update code.jquery.com to https #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

update code.jquery.com to https #19

wants to merge 1 commit into from

Conversation

OmgImAlexis
Copy link

Since there's so many files in this I'm going to do multiple PRs.
These are mass updates using find and replace, I do check the domains before doing this.

http://code.jquery.com was replaced with https://code.jquery.com.

@jaspermdegroot
Copy link
Member

@OmgImAlexis

First of all, thanks for the PR!
I don't think we should make changes in demos after they have been released, even if it's an improvement. The demos are also included in the ZIP-file of each release and those should be identical to the ones we publish on our web site.
@arschmitz what do you think?

@OmgImAlexis
Copy link
Author

@jaspermdegroot why not just force code.jquery.com and all other domains to force a http -> https redirect and enable HSTS? I've noticed there's no force redirect for a lot of your domains as I can still use curl or wget to access the http version and HSTS would mean browsers would know to only allow https. You guys might also want to look into adding the jquery domains to https://hstspreload.appspot.com/ so major browsers never allow http versions to be loaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants